diff --git a/DGIdGateway/APRSWriter.cpp b/DGIdGateway/APRSWriter.cpp index ae9e7cb..9598456 100644 --- a/DGIdGateway/APRSWriter.cpp +++ b/DGIdGateway/APRSWriter.cpp @@ -36,8 +36,8 @@ m_longitude(0.0F), m_height(0), m_desc(), m_suffix(suffix), -m_aprsAddress(), -m_aprsPort(port), +m_aprsAddr(), +m_aprsAddrLen(), m_aprsSocket() #if defined(USE_GPSD) ,m_gpsdEnabled(false), @@ -55,7 +55,7 @@ m_gpsdData() m_callsign.append(rptSuffix.substr(0U, 1U)); } - m_aprsAddress = CUDPSocket::lookup(address); + CUDPSocket::lookup(address, port, m_aprsAddr, m_aprsAddrLen); } CAPRSWriter::~CAPRSWriter() @@ -176,7 +176,7 @@ void CAPRSWriter::write(const unsigned char* source, const char* type, unsigned if (m_debug) LogDebug("APRS ==> %s", output); - m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddress, m_aprsPort); + m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddr, m_aprsAddrLen); } void CAPRSWriter::clock(unsigned int ms) @@ -275,7 +275,7 @@ void CAPRSWriter::sendIdFrameFixed() if (m_debug) LogDebug("APRS ==> %s", output); - m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddress, m_aprsPort); + m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddr, m_aprsAddrLen); } #if defined(USE_GPSD) @@ -376,6 +376,6 @@ void CAPRSWriter::sendIdFrameMobile() if (m_debug) LogDebug("APRS ==> %s", output); - m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddress, m_aprsPort); + m_aprsSocket.write((unsigned char*)output, (unsigned int)::strlen(output), m_aprsAddr, m_aprsAddrLen); } #endif diff --git a/DGIdGateway/APRSWriter.h b/DGIdGateway/APRSWriter.h index f014b20..8f46f35 100644 --- a/DGIdGateway/APRSWriter.h +++ b/DGIdGateway/APRSWriter.h @@ -70,8 +70,8 @@ private: int m_height; std::string m_desc; std::string m_suffix; - in_addr m_aprsAddress; - unsigned int m_aprsPort; + sockaddr_storage m_aprsAddr; + unsigned int m_aprsAddrLen; CUDPSocket m_aprsSocket; #if defined(USE_GPSD) bool m_gpsdEnabled; diff --git a/DGIdGateway/DGIdGateway.cpp b/DGIdGateway/DGIdGateway.cpp index dcce203..8c8ee59 100644 --- a/DGIdGateway/DGIdGateway.cpp +++ b/DGIdGateway/DGIdGateway.cpp @@ -180,13 +180,15 @@ int CDGIdGateway::run() m_callsign = m_conf.getCallsign(); m_suffix = m_conf.getSuffix(); + sockaddr_storage rptAddr; + unsigned int rptAddrLen; + CUDPSocket::lookup(m_conf.getRptAddress(), m_conf.getRptPort(), rptAddr, rptAddrLen); + bool debug = m_conf.getDebug(); - in_addr rptAddress = CUDPSocket::lookup(m_conf.getRptAddress()); - unsigned int rptPort = m_conf.getRptPort(); std::string myAddress = m_conf.getMyAddress(); unsigned int myPort = m_conf.getMyPort(); - CYSFNetwork rptNetwork(myAddress, myPort, "MMDVM", rptAddress, rptPort, m_callsign, debug); + CYSFNetwork rptNetwork(myAddress, myPort, "MMDVM", rptAddr, rptAddrLen, m_callsign, debug); ret = rptNetwork.open(); if (!ret) { ::LogError("Cannot open the repeater network port"); @@ -239,7 +241,7 @@ int CDGIdGateway::run() CYSFReflector* reflector = reflectors->findByName(name); if (reflector != NULL) { - dgIdNetwork[dgid] = new CYSFNetwork(local, reflector->m_name, reflector->m_address, reflector->m_port, m_callsign, debug);; + dgIdNetwork[dgid] = new CYSFNetwork(local, reflector->m_name, reflector->m_addr, reflector->m_addrLen, m_callsign, debug);; dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2 | DT_VOICE_FR_MODE | DT_DATA_FR_MODE; dgIdNetwork[dgid]->m_static = statc; dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; @@ -253,8 +255,8 @@ int CDGIdGateway::run() for (std::vector::const_iterator it = destinations.begin(); it != destinations.end(); ++it) { IMRSDest* dest = new IMRSDest; - dest->m_address = CUDPSocket::lookup((*it)->m_address); - dest->m_dgId = (*it)->m_dgId; + CUDPSocket::lookup((*it)->m_address, IMRS_PORT, dest->m_addr, dest->m_addrLen); + dest->m_dgId = (*it)->m_dgId; dests.push_back(dest); } @@ -267,53 +269,53 @@ int CDGIdGateway::run() dgIdNetwork[dgid]->m_netHangTime = netHangTime; } } else if (type == "Parrot") { - in_addr address = CUDPSocket::lookup((*it)->m_address); - unsigned int port = (*it)->m_port; unsigned int local = (*it)->m_local; - if (address.s_addr != INADDR_NONE) { - dgIdNetwork[dgid] = new CYSFNetwork(local, "PARROT", address, port, m_callsign, debug); - dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2 | DT_VOICE_FR_MODE | DT_DATA_FR_MODE; - dgIdNetwork[dgid]->m_static = statc; - dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; - dgIdNetwork[dgid]->m_netHangTime = netHangTime; - } + sockaddr_storage addr; + unsigned int addrLen; + CUDPSocket::lookup((*it)->m_address, (*it)->m_port, addr, addrLen); + + dgIdNetwork[dgid] = new CYSFNetwork(local, "PARROT", addr, addrLen, m_callsign, debug); + dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2 | DT_VOICE_FR_MODE | DT_DATA_FR_MODE; + dgIdNetwork[dgid]->m_static = statc; + dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; + dgIdNetwork[dgid]->m_netHangTime = netHangTime; } else if (type == "YSF2DMR") { - in_addr address = CUDPSocket::lookup((*it)->m_address); - unsigned int port = (*it)->m_port; unsigned int local = (*it)->m_local; - if (address.s_addr != INADDR_NONE) { - dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2DMR", address, port, m_callsign, debug); - dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2; - dgIdNetwork[dgid]->m_static = statc; - dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; - dgIdNetwork[dgid]->m_netHangTime = netHangTime; - } + sockaddr_storage addr; + unsigned int addrLen; + CUDPSocket::lookup((*it)->m_address, (*it)->m_port, addr, addrLen); + + dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2DMR", addr, addrLen, m_callsign, debug); + dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2; + dgIdNetwork[dgid]->m_static = statc; + dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; + dgIdNetwork[dgid]->m_netHangTime = netHangTime; } else if (type == "YSF2NXDN") { - in_addr address = CUDPSocket::lookup((*it)->m_address); - unsigned int port = (*it)->m_port; unsigned int local = (*it)->m_local; - if (address.s_addr != INADDR_NONE) { - dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2NXDN", address, port, m_callsign, debug); - dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2; - dgIdNetwork[dgid]->m_static = statc; - dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; - dgIdNetwork[dgid]->m_netHangTime = netHangTime; - } + sockaddr_storage addr; + unsigned int addrLen; + CUDPSocket::lookup((*it)->m_address, (*it)->m_port, addr, addrLen); + + dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2NXDN", addr, addrLen, m_callsign, debug); + dgIdNetwork[dgid]->m_modes = DT_VD_MODE1 | DT_VD_MODE2; + dgIdNetwork[dgid]->m_static = statc; + dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; + dgIdNetwork[dgid]->m_netHangTime = netHangTime; } else if (type == "YSF2P25") { - in_addr address = CUDPSocket::lookup((*it)->m_address); - unsigned int port = (*it)->m_port; unsigned int local = (*it)->m_local; - if (address.s_addr != INADDR_NONE) { - dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2P25", address, port, m_callsign, debug); - dgIdNetwork[dgid]->m_modes = DT_VOICE_FR_MODE; - dgIdNetwork[dgid]->m_static = statc; - dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; - dgIdNetwork[dgid]->m_netHangTime = netHangTime; - } + sockaddr_storage addr; + unsigned int addrLen; + CUDPSocket::lookup((*it)->m_address, (*it)->m_port, addr, addrLen); + + dgIdNetwork[dgid] = new CYSFNetwork(local, "YSF2P25", addr, addrLen, m_callsign, debug); + dgIdNetwork[dgid]->m_modes = DT_VOICE_FR_MODE; + dgIdNetwork[dgid]->m_static = statc; + dgIdNetwork[dgid]->m_rfHangTime = rfHangTime; + dgIdNetwork[dgid]->m_netHangTime = netHangTime; } if (dgIdNetwork[dgid] != NULL && dgIdNetwork[dgid] != imrs) { diff --git a/DGIdGateway/FCSNetwork.cpp b/DGIdGateway/FCSNetwork.cpp index fafd213..1f0cb9c 100644 --- a/DGIdGateway/FCSNetwork.cpp +++ b/DGIdGateway/FCSNetwork.cpp @@ -32,7 +32,8 @@ const unsigned int BUFFER_LENGTH = 200U; CFCSNetwork::CFCSNetwork(const std::string& reflector, unsigned int port, const std::string& callsign, unsigned int rxFrequency, unsigned int txFrequency, const std::string& locator, unsigned int id, bool debug) : m_socket(port), m_debug(debug), -m_address(), +m_addr(), +m_addrLen(0U), m_ping(NULL), m_info(NULL), m_reflector(reflector), @@ -72,16 +73,48 @@ bool CFCSNetwork::open() { LogMessage("Resolving FCS00x addresses"); - m_addresses["FCS001"] = CUDPSocket::lookup("fcs001.xreflector.net"); - m_addresses["FCS002"] = CUDPSocket::lookup("fcs002.xreflector.net"); - m_addresses["FCS003"] = CUDPSocket::lookup("fcs003.xreflector.net"); - m_addresses["FCS004"] = CUDPSocket::lookup("fcs004.xreflector.net"); - m_addresses["FCS005"] = CUDPSocket::lookup("fcs005.xreflector.net"); - m_addresses["FCS222"] = CUDPSocket::lookup("fcs222.xreflector.net"); - m_addresses["FCS224"] = CUDPSocket::lookup("fcs224.xreflector.net"); - m_addresses["FCS232"] = CUDPSocket::lookup("fcs232.xreflector.net"); - m_addresses["FCS260"] = CUDPSocket::lookup("fcs260.xreflector.net"); - m_addresses["FCS262"] = CUDPSocket::lookup("fcs262.xreflector.net"); + sockaddr_storage addr; + unsigned int addrLen; + + CUDPSocket::lookup("fcs001.xreflector.net", FCS_PORT, addr, addrLen); + std::pair entry = std::make_pair(addr, addrLen); + m_addresses["FCS001"] = entry; + + CUDPSocket::lookup("fcs002.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS002"] = entry; + + CUDPSocket::lookup("fcs003.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS003"] = entry; + + CUDPSocket::lookup("fcs004.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS004"] = entry; + + CUDPSocket::lookup("fcs005.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS005"] = entry; + + CUDPSocket::lookup("fcs222.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS222"] = entry; + + CUDPSocket::lookup("fcs224.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS224"] = entry; + + CUDPSocket::lookup("fcs232.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS232"] = entry; + + CUDPSocket::lookup("fcs260.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS260"] = entry; + + CUDPSocket::lookup("fcs262.xreflector.net", FCS_PORT, addr, addrLen); + entry = std::make_pair(addr, addrLen); + m_addresses["FCS262"] = entry; LogMessage("Opening FCS network connection"); @@ -103,7 +136,7 @@ void CFCSNetwork::write(unsigned int dgid, const unsigned char* data) if (m_debug) CUtils::dump(1U, "FCS Network Data Sent", buffer, 130U); - m_socket.write(buffer, 130U, m_address, FCS_PORT); + m_socket.write(buffer, 130U, m_addr, m_addrLen); } void CFCSNetwork::link() @@ -117,11 +150,9 @@ void CFCSNetwork::link() return; } - m_address = m_addresses[name]; - if (m_address.s_addr == INADDR_NONE) { - LogError("FCS reflector %s has no address", name.c_str()); - return; - } + std::pair entry = m_addresses[name]; + m_addr = entry.first; + m_addrLen = entry.second; m_state = FCS_LINKING; @@ -135,7 +166,7 @@ void CFCSNetwork::unlink() if (m_state != FCS_LINKED) return; - m_socket.write((unsigned char*)"CLOSE ", 11U, m_address, FCS_PORT); + m_socket.write((unsigned char*)"CLOSE ", 11U, m_addr, m_addrLen); } void CFCSNetwork::clock(unsigned int ms) @@ -154,16 +185,16 @@ void CFCSNetwork::clock(unsigned int ms) unsigned char buffer[BUFFER_LENGTH]; - in_addr address; - unsigned int port; - int length = m_socket.read(buffer, BUFFER_LENGTH, address, port); + sockaddr_storage addr; + unsigned int addrLen; + int length = m_socket.read(buffer, BUFFER_LENGTH, addr, addrLen); if (length <= 0) return; if (m_state == FCS_UNLINKED) return; - if (address.s_addr != m_address.s_addr || port != FCS_PORT) + if (!CUDPSocket::match(addr, m_addr)) return; if (m_debug) @@ -242,7 +273,7 @@ void CFCSNetwork::writeInfo() if (m_debug) CUtils::dump(1U, "FCS Network Data Sent", m_info, 100U); - m_socket.write(m_info, 100U, m_address, FCS_PORT); + m_socket.write(m_info, 100U, m_addr, m_addrLen); } void CFCSNetwork::writePing() @@ -253,5 +284,5 @@ void CFCSNetwork::writePing() if (m_debug) CUtils::dump(1U, "FCS Network Data Sent", m_ping, 25U); - m_socket.write(m_ping, 25U, m_address, FCS_PORT); + m_socket.write(m_ping, 25U, m_addr, m_addrLen); } diff --git a/DGIdGateway/FCSNetwork.h b/DGIdGateway/FCSNetwork.h index 4f6c9ec..a0d2d67 100644 --- a/DGIdGateway/FCSNetwork.h +++ b/DGIdGateway/FCSNetwork.h @@ -59,13 +59,14 @@ public: private: CUDPSocket m_socket; bool m_debug; - in_addr m_address; + sockaddr_storage m_addr; + unsigned int m_addrLen; unsigned char* m_ping; unsigned char* m_info; std::string m_reflector; std::string m_print; CRingBuffer m_buffer; - std::map m_addresses; + std::map> m_addresses; unsigned char m_n; CTimer m_pingTimer; CTimer m_resetTimer; diff --git a/DGIdGateway/IMRSNetwork.cpp b/DGIdGateway/IMRSNetwork.cpp index e084758..a61eb11 100644 --- a/DGIdGateway/IMRSNetwork.cpp +++ b/DGIdGateway/IMRSNetwork.cpp @@ -26,8 +26,6 @@ #include #include -const unsigned int IMRS_PORT = 21110U; - CIMRSNetwork::CIMRSNetwork() : m_socket(IMRS_PORT), @@ -134,7 +132,7 @@ void CIMRSNetwork::write(unsigned int dgId, const unsigned char* data) if (ptr->m_debug) CUtils::dump(1U, "IMRS Network Data Sent", buffer, 165U); - m_socket.write(buffer, 165U, (*it)->m_address, IMRS_PORT); + m_socket.write(buffer, 165U, (*it)->m_addr, (*it)->m_addrLen); } } @@ -150,20 +148,19 @@ void CIMRSNetwork::clock(unsigned int ms) { unsigned char buffer[500U]; - in_addr address; - unsigned int port; - int length = m_socket.read(buffer, 500U, address, port); + sockaddr_storage addr; + unsigned int addrLen; + int length = m_socket.read(buffer, 500U, addr, addrLen); if (length <= 0) return; - LogDebug("IMRS Network Data Reecived from port %u", port); CUtils::dump(1U, "IMRS Network Data Received", buffer, length); return; - if (port != IMRS_PORT) - return; + // if (port != IMRS_PORT) + // return; - IMRSDGId* ptr = find(address); + IMRSDGId* ptr = find(addr); if (ptr == NULL) return; @@ -201,11 +198,11 @@ void CIMRSNetwork::close() m_socket.close(); } -IMRSDGId* CIMRSNetwork::find(in_addr address) const +IMRSDGId* CIMRSNetwork::find(const sockaddr_storage& addr) const { for (std::vector::const_iterator it1 = m_dgIds.begin(); it1 != m_dgIds.end(); ++it1) { for (std::vector::const_iterator it2 = (*it1)->m_destinations.begin(); it2 != (*it1)->m_destinations.end(); ++it2) { - if (address.s_addr == (*it2)->m_address.s_addr) + if (CUDPSocket::match(addr, (*it2)->m_addr)) return *it1; } } diff --git a/DGIdGateway/IMRSNetwork.h b/DGIdGateway/IMRSNetwork.h index e0738a0..e7d8405 100644 --- a/DGIdGateway/IMRSNetwork.h +++ b/DGIdGateway/IMRSNetwork.h @@ -28,8 +28,9 @@ #include struct IMRSDest { - in_addr m_address; - unsigned int m_dgId; + sockaddr_storage m_addr; + unsigned int m_addrLen; + unsigned int m_dgId; }; class IMRSDGId { @@ -76,7 +77,7 @@ private: CUDPSocket m_socket; std::vector m_dgIds; - IMRSDGId* find(in_addr address) const; + IMRSDGId* find(const sockaddr_storage& address) const; IMRSDGId* find(unsigned int dgId) const; }; diff --git a/DGIdGateway/UDPSocket.cpp b/DGIdGateway/UDPSocket.cpp index 733dd20..659d816 100644 --- a/DGIdGateway/UDPSocket.cpp +++ b/DGIdGateway/UDPSocket.cpp @@ -1,5 +1,5 @@ /* - * Copyright (C) 2006-2016 by Jonathan Naylor G4KLX + * Copyright (C) 2006-2016,2020 by Jonathan Naylor G4KLX * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -62,49 +62,91 @@ CUDPSocket::~CUDPSocket() #endif } -in_addr CUDPSocket::lookup(const std::string& hostname) +int CUDPSocket::lookup(const std::string& hostname, unsigned int port, sockaddr_storage& addr, unsigned int& address_length) { - in_addr addr; -#if defined(_WIN32) || defined(_WIN64) - unsigned long address = ::inet_addr(hostname.c_str()); - if (address != INADDR_NONE && address != INADDR_ANY) { - addr.s_addr = address; - return addr; - } + struct addrinfo hints; + ::memset(&hints, 0, sizeof(hints)); + + return lookup(hostname, port, addr, address_length, hints); +} - struct hostent* hp = ::gethostbyname(hostname.c_str()); - if (hp != NULL) { - ::memcpy(&addr, hp->h_addr_list[0], sizeof(struct in_addr)); - return addr; +int CUDPSocket::lookup(const std::string& hostname, unsigned int port, sockaddr_storage& addr, unsigned int& address_length, struct addrinfo& hints) +{ + std::string portstr = std::to_string(port); + struct addrinfo *res; + + /* port is always digits, no needs to lookup service */ + hints.ai_flags |= AI_NUMERICSERV; + + int err = getaddrinfo(hostname.empty() ? NULL : hostname.c_str(), portstr.c_str(), &hints, &res); + if (err != 0) { + sockaddr_in* paddr = (sockaddr_in*)&addr; + ::memset(paddr, 0x00U, address_length = sizeof(sockaddr_in)); + paddr->sin_family = AF_INET; + paddr->sin_port = htons(port); + paddr->sin_addr.s_addr = htonl(INADDR_NONE); + LogError("Cannot find address for host %s", hostname.c_str()); + return err; } - LogError("Cannot find address for host %s", hostname.c_str()); + ::memcpy(&addr, res->ai_addr, address_length = res->ai_addrlen); - addr.s_addr = INADDR_NONE; - return addr; -#else - in_addr_t address = ::inet_addr(hostname.c_str()); - if (address != in_addr_t(-1)) { - addr.s_addr = address; - return addr; - } + freeaddrinfo(res); + + return 0; +} + +bool CUDPSocket::match(const sockaddr_storage& addr1, const sockaddr_storage& addr2) +{ + if (addr1.ss_family != addr2.ss_family) + return false; - struct hostent* hp = ::gethostbyname(hostname.c_str()); - if (hp != NULL) { - ::memcpy(&addr, hp->h_addr_list[0], sizeof(struct in_addr)); - return addr; + switch (addr1.ss_family) { + case AF_INET: + struct sockaddr_in *in_1, *in_2; + in_1 = (struct sockaddr_in*)&addr1; + in_2 = (struct sockaddr_in*)&addr2; + return ((in_1->sin_addr.s_addr == in_2->sin_addr.s_addr) && (in_1->sin_port == in_2->sin_port)); + case AF_INET6: + struct sockaddr_in6 *in6_1, *in6_2; + in6_1 = (struct sockaddr_in6*)&addr1; + in6_2 = (struct sockaddr_in6*)&addr2; + return (IN6_ARE_ADDR_EQUAL(&in6_1->sin6_addr, &in6_2->sin6_addr) && (in6_1->sin6_port == in6_2->sin6_port)); + default: + return false; } +} - LogError("Cannot find address for host %s", hostname.c_str()); +bool CUDPSocket::isnone(const sockaddr_storage& addr) +{ + struct sockaddr_in *in = (struct sockaddr_in *)&addr; - addr.s_addr = INADDR_NONE; - return addr; -#endif + return ((addr.ss_family == AF_INET) && (in->sin_addr.s_addr == htonl(INADDR_NONE))); } bool CUDPSocket::open() { - m_fd = ::socket(PF_INET, SOCK_DGRAM, 0); + return open(AF_UNSPEC); +} + +bool CUDPSocket::open(const unsigned int af) +{ + sockaddr_storage addr; + unsigned int addrlen; + struct addrinfo hints; + + ::memset(&hints, 0, sizeof(hints)); + hints.ai_flags = AI_PASSIVE; + hints.ai_family = af; + + /* to determine protocol family, call lookup() first. */ + int err = lookup(m_address, m_port, addr, addrlen, hints); + if (err != 0) { + LogError("The local address is invalid - %s", m_address.c_str()); + return false; + } + + m_fd = ::socket(addr.ss_family, SOCK_DGRAM, 0); if (m_fd < 0) { #if defined(_WIN32) || defined(_WIN64) LogError("Cannot create the UDP socket, err: %lu", ::GetLastError()); @@ -115,24 +157,6 @@ bool CUDPSocket::open() } if (m_port > 0U) { - sockaddr_in addr; - ::memset(&addr, 0x00, sizeof(sockaddr_in)); - addr.sin_family = AF_INET; - addr.sin_port = htons(m_port); - addr.sin_addr.s_addr = htonl(INADDR_ANY); - - if (!m_address.empty()) { -#if defined(_WIN32) || defined(_WIN64) - addr.sin_addr.s_addr = ::inet_addr(m_address.c_str()); -#else - addr.sin_addr.s_addr = ::inet_addr(m_address.c_str()); -#endif - if (addr.sin_addr.s_addr == INADDR_NONE) { - LogError("The local address is invalid - %s", m_address.c_str()); - return false; - } - } - int reuse = 1; if (::setsockopt(m_fd, SOL_SOCKET, SO_REUSEADDR, (char *)&reuse, sizeof(reuse)) == -1) { #if defined(_WIN32) || defined(_WIN64) @@ -143,7 +167,7 @@ bool CUDPSocket::open() return false; } - if (::bind(m_fd, (sockaddr*)&addr, sizeof(sockaddr_in)) == -1) { + if (::bind(m_fd, (sockaddr*)&addr, addrlen) == -1) { #if defined(_WIN32) || defined(_WIN64) LogError("Cannot bind the UDP address, err: %lu", ::GetLastError()); #else @@ -158,7 +182,7 @@ bool CUDPSocket::open() return true; } -int CUDPSocket::read(unsigned char* buffer, unsigned int length, in_addr& address, unsigned int& port) +int CUDPSocket::read(unsigned char* buffer, unsigned int length, sockaddr_storage& address, unsigned int &address_length) { assert(buffer != NULL); assert(length > 0U); @@ -190,17 +214,16 @@ int CUDPSocket::read(unsigned char* buffer, unsigned int length, in_addr& addres if (ret == 0) return 0; - sockaddr_in addr; #if defined(_WIN32) || defined(_WIN64) - int size = sizeof(sockaddr_in); + int size = sizeof(sockaddr_storage); #else - socklen_t size = sizeof(sockaddr_in); + socklen_t size = sizeof(sockaddr_storage); #endif #if defined(_WIN32) || defined(_WIN64) - int len = ::recvfrom(m_fd, (char*)buffer, length, 0, (sockaddr *)&addr, &size); + int len = ::recvfrom(m_fd, (char*)buffer, length, 0, (sockaddr *)&address, &size); #else - ssize_t len = ::recvfrom(m_fd, (char*)buffer, length, 0, (sockaddr *)&addr, &size); + ssize_t len = ::recvfrom(m_fd, (char*)buffer, length, 0, (sockaddr *)&address, &size); #endif if (len <= 0) { #if defined(_WIN32) || defined(_WIN64) @@ -211,28 +234,19 @@ int CUDPSocket::read(unsigned char* buffer, unsigned int length, in_addr& addres return -1; } - address = addr.sin_addr; - port = ntohs(addr.sin_port); - + address_length = size; return len; } -bool CUDPSocket::write(const unsigned char* buffer, unsigned int length, const in_addr& address, unsigned int port) +bool CUDPSocket::write(const unsigned char* buffer, unsigned int length, const sockaddr_storage& address, unsigned int address_length) { assert(buffer != NULL); assert(length > 0U); - sockaddr_in addr; - ::memset(&addr, 0x00, sizeof(sockaddr_in)); - - addr.sin_family = AF_INET; - addr.sin_addr = address; - addr.sin_port = htons(port); - #if defined(_WIN32) || defined(_WIN64) - int ret = ::sendto(m_fd, (char *)buffer, length, 0, (sockaddr *)&addr, sizeof(sockaddr_in)); + int ret = ::sendto(m_fd, (char *)buffer, length, 0, (sockaddr *)&address, address_length); #else - ssize_t ret = ::sendto(m_fd, (char *)buffer, length, 0, (sockaddr *)&addr, sizeof(sockaddr_in)); + ssize_t ret = ::sendto(m_fd, (char *)buffer, length, 0, (sockaddr *)&address, address_length); #endif if (ret < 0) { #if defined(_WIN32) || defined(_WIN64) diff --git a/DGIdGateway/UDPSocket.h b/DGIdGateway/UDPSocket.h index e0af272..386f059 100644 --- a/DGIdGateway/UDPSocket.h +++ b/DGIdGateway/UDPSocket.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2009-2011,2013,2015,2016 by Jonathan Naylor G4KLX + * Copyright (C) 2009-2011,2013,2015,2016,2020 by Jonathan Naylor G4KLX * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -31,7 +31,8 @@ #include #include #else -#include +#include +#include #endif class CUDPSocket { @@ -41,13 +42,17 @@ public: ~CUDPSocket(); bool open(); + bool open(const unsigned int af); - int read(unsigned char* buffer, unsigned int length, in_addr& address, unsigned int& port); - bool write(const unsigned char* buffer, unsigned int length, const in_addr& address, unsigned int port); + int read(unsigned char* buffer, unsigned int length, sockaddr_storage& address, unsigned int &address_length); + bool write(const unsigned char* buffer, unsigned int length, const sockaddr_storage& address, unsigned int address_length); void close(); - static in_addr lookup(const std::string& hostName); + static int lookup(const std::string& hostName, unsigned int port, sockaddr_storage& address, unsigned int& address_length); + static int lookup(const std::string& hostName, unsigned int port, sockaddr_storage& address, unsigned int& address_length, struct addrinfo& hints); + static bool match(const sockaddr_storage& addr1, const sockaddr_storage& addr2); + static bool isnone(const sockaddr_storage& addr); private: std::string m_address; diff --git a/DGIdGateway/Version.h b/DGIdGateway/Version.h index e99254c..ff2325e 100644 --- a/DGIdGateway/Version.h +++ b/DGIdGateway/Version.h @@ -19,6 +19,6 @@ #if !defined(VERSION_H) #define VERSION_H -const char* VERSION = "20200824"; +const char* VERSION = "20200903"; #endif diff --git a/DGIdGateway/YSFDefines.h b/DGIdGateway/YSFDefines.h index b2aefc6..2f65b25 100644 --- a/DGIdGateway/YSFDefines.h +++ b/DGIdGateway/YSFDefines.h @@ -49,4 +49,6 @@ const unsigned char YSF_MR_BUSY = 0x02U; const unsigned int FCS_PORT = 62500U; +const unsigned int IMRS_PORT = 21110U; + #endif diff --git a/DGIdGateway/YSFNetwork.cpp b/DGIdGateway/YSFNetwork.cpp index d007024..eb0736d 100644 --- a/DGIdGateway/YSFNetwork.cpp +++ b/DGIdGateway/YSFNetwork.cpp @@ -27,11 +27,11 @@ const unsigned int BUFFER_LENGTH = 200U; -CYSFNetwork::CYSFNetwork(const std::string& localAddress, unsigned int localPort, const std::string& name, const in_addr& address, unsigned int port, const std::string& callsign, bool debug) : +CYSFNetwork::CYSFNetwork(const std::string& localAddress, unsigned int localPort, const std::string& name, const sockaddr_storage& addr, unsigned int addrLen, const std::string& callsign, bool debug) : m_socket(localAddress, localPort), m_debug(debug), -m_address(address), -m_port(port), +m_addr(addr), +m_addrLen(addrLen), m_poll(NULL), m_unlink(NULL), m_buffer(1000U, "YSF Network Buffer"), @@ -54,11 +54,11 @@ m_linked(true) } } -CYSFNetwork::CYSFNetwork(unsigned int localPort, const std::string& name, const in_addr& address, unsigned int port, const std::string& callsign, bool debug) : +CYSFNetwork::CYSFNetwork(unsigned int localPort, const std::string& name, const sockaddr_storage& addr, unsigned int addrLen, const std::string& callsign, bool debug) : m_socket(localPort), m_debug(debug), -m_address(address), -m_port(port), +m_addr(addr), +m_addrLen(addrLen), m_poll(NULL), m_unlink(NULL), m_buffer(1000U, "YSF Network Buffer"), @@ -108,7 +108,7 @@ void CYSFNetwork::write(unsigned int dgid, const unsigned char* data) if (m_debug) CUtils::dump(1U, "YSF Network Data Sent", data, 155U); - m_socket.write(data, 155U, m_address, m_port); + m_socket.write(data, 155U, m_addr, m_addrLen); } void CYSFNetwork::link() @@ -120,36 +120,35 @@ void CYSFNetwork::writePoll() { m_pollTimer.start(); - m_socket.write(m_poll, 14U, m_address, m_port); + m_socket.write(m_poll, 14U, m_addr, m_addrLen); } void CYSFNetwork::unlink() { m_pollTimer.stop(); - m_socket.write(m_unlink, 14U, m_address, m_port); + m_socket.write(m_unlink, 14U, m_addr, m_addrLen); m_linked = false; } void CYSFNetwork::clock(unsigned int ms) { - unsigned char buffer[BUFFER_LENGTH]; - in_addr address; - unsigned int port; - m_pollTimer.clock(ms); if (m_pollTimer.isRunning() && m_pollTimer.hasExpired()) writePoll(); - int length = m_socket.read(buffer, BUFFER_LENGTH, address, port); + unsigned char buffer[BUFFER_LENGTH]; + sockaddr_storage addr; + unsigned int addrLen; + int length = m_socket.read(buffer, BUFFER_LENGTH, addr, addrLen); if (length <= 0) return; - if (m_port == 0U) + if (m_addrLen == 0U) return; - if (address.s_addr != m_address.s_addr || port != m_port) + if (!CUDPSocket::match(addr, m_addr)) return; if (::memcmp(buffer, "YSFP", 4U) == 0 && !m_linked) { diff --git a/DGIdGateway/YSFNetwork.h b/DGIdGateway/YSFNetwork.h index 100e8a6..36eda05 100644 --- a/DGIdGateway/YSFNetwork.h +++ b/DGIdGateway/YSFNetwork.h @@ -30,8 +30,8 @@ class CYSFNetwork : public CDGIdNetwork { public: - CYSFNetwork(const std::string& localAddress, unsigned int localPort, const std::string& name, const in_addr& address, unsigned int port, const std::string& callsign, bool debug); - CYSFNetwork(unsigned int localPort, const std::string& name, const in_addr& address, unsigned int port, const std::string& callsign, bool debug); + CYSFNetwork(const std::string& localAddress, unsigned int localPort, const std::string& name, const sockaddr_storage& addr, unsigned int addrLen, const std::string& callsign, bool debug); + CYSFNetwork(unsigned int localPort, const std::string& name, const sockaddr_storage& addr, unsigned int addrLen, const std::string& callsign, bool debug); virtual ~CYSFNetwork(); virtual std::string getDesc(unsigned int dgId); @@ -53,8 +53,8 @@ public: private: CUDPSocket m_socket; bool m_debug; - in_addr m_address; - unsigned int m_port; + sockaddr_storage m_addr; + unsigned int m_addrLen; unsigned char* m_poll; unsigned char* m_unlink; CRingBuffer m_buffer; diff --git a/DGIdGateway/YSFReflectors.cpp b/DGIdGateway/YSFReflectors.cpp index 2e97542..277ac4c 100644 --- a/DGIdGateway/YSFReflectors.cpp +++ b/DGIdGateway/YSFReflectors.cpp @@ -57,18 +57,15 @@ bool CYSFReflectors::load() char* p6 = ::strtok(NULL, "\r\n"); if (p1 != NULL && p2 != NULL && p3 != NULL && p4 != NULL && p5 != NULL && p6 != NULL) { - std::string host = std::string(p4); - - in_addr address = CUDPSocket::lookup(host); - if (address.s_addr != INADDR_NONE) { - CYSFReflector* refl = new CYSFReflector; - refl->m_id = std::string(p1); - refl->m_name = std::string(p2); - refl->m_address = address; - refl->m_port = (unsigned int)::atoi(p5); - - m_reflectors.push_back(refl); - } + std::string host = std::string(p4); + unsigned int port = (unsigned int)::atoi(p5); + + CYSFReflector* refl = new CYSFReflector; + CUDPSocket::lookup(host, port, refl->m_addr, refl->m_addrLen); + refl->m_id = std::string(p1); + refl->m_name = std::string(p2); + + m_reflectors.push_back(refl); } } diff --git a/DGIdGateway/YSFReflectors.h b/DGIdGateway/YSFReflectors.h index aa17b39..e4c5b44 100644 --- a/DGIdGateway/YSFReflectors.h +++ b/DGIdGateway/YSFReflectors.h @@ -29,15 +29,15 @@ public: CYSFReflector() : m_id(), m_name(), - m_address(), - m_port(0U) + m_addr(), + m_addrLen(0U) { } - std::string m_id; - std::string m_name; - in_addr m_address; - unsigned int m_port; + std::string m_id; + std::string m_name; + sockaddr_storage m_addr; + unsigned int m_addrLen; }; class CYSFReflectors {