Localize variables, improve readability

modules/dpkg/functions/deb-clone

@@ -6,11 +6,21 @@
 #   Sorin Ionescu <sorin.ionescu@gmail.com>
 #
 
-print '#!/bin/sh'"\n" > apt-copy.sh
+local clone_script="${0}.sh"
+local package_list=$(
+  perl \
+    -m 'AptPkg::Cache' \
+    -e '
+      $c=AptPkg::Cache->new;
+      for (keys %$c) {
+        push @a, $_ if $c->{$_}->{'CurrentState'} eq 'Installed';
+      }
+      print "$_ " for sort @a;
+    '
+)
 
-list=$(perl -m'AptPkg::Cache' -e '$c=AptPkg::Cache->new; for (keys %$c){ push @a, $_ if $c->{$_}->{'CurrentState'} eq 'Installed';} print "$_ " for sort @a;')
+rm "$clone_script"
-
+print '#!/bin/sh\n' > "$clone_script"
-print 'aptitude install '"$list\n" >> apt-copy.sh
+print "aptitude install ${package_list}\n" >> "$clone_script"
-
+chmod +x "$clone_script"
-chmod +x apt-copy.sh